Messages in this thread | | | Date | Wed, 12 Nov 2008 11:08:00 -0500 | From | "Mike Frysinger" <> | Subject | Re: [PATCH] physmap: Fix leak of memory returned by parse_mtd_partitions |
| |
On Wed, Nov 12, 2008 at 10:55, Atsushi Nemoto wrote: > On Wed, 12 Nov 2008 23:57:33 +0900 (JST), Atsushi Nemoto wrote: >> The mtd partition parser returns an allocated pointer array of >> mtd_partition. The caller must free it. The array is used only for >> add_mtd_partitions(), so free it just after the call. >> >> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp> >> --- >> drivers/mtd/maps/physmap.c | 17 ++++++++--------- >> 1 files changed, 8 insertions(+), 9 deletions(-) > > And many other callers of parse_mtd_partitions() also do not free the > returned memory. With a quick look, 21 of 36 have same defect.
i wonder why we duplicate this same code block in so many places. and why does every driver have to declare its own list of parsers ? cant we unify all of these in one place ?
> drivers/mtd/maps/bfin-async-flash.c
i can fix this one if no one else gets to it -mikex
| |