lkml.org 
[lkml]   [2008]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][RESEND] checkpatch: Add warning for p0-patches
On Fri, Oct 31, 2008 at 04:36:10PM +0100, Wolfram Sang wrote:
> Some people work internally with -p0-patches which has the danger that
> one forgets to convert them to -p1 before mainlining. Bitten myself and
> seen p0-patches in mailing lists occasionally, this patch adds a warning
> to checkpatch.pl in case a patch is -p0. If you really want, you can
> fool this check to generate false positives, this is why it just spits a
> warning. Making the check 100% proof is trickier than it looks, so let's
> start with a version which catches the cases of real use.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
> scripts/checkpatch.pl | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index f88bb3e..dae5854 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1051,6 +1051,7 @@ sub process {
> my $in_comment = 0;
> my $comment_edge = 0;
> my $first_line = 0;
> + my $p1_prefix = '';
>
> my $prev_values = 'E';
>
> @@ -1196,7 +1197,12 @@ sub process {
> # extract the filename as it passes
> if ($line=~/^\+\+\+\s+(\S+)/) {
> $realfile = $1;
> - $realfile =~ s@^[^/]*/@@;
> + $realfile =~ s@^([^/]*)/@@;
> +
> + $p1_prefix = $1;
> + if ($tree && -e "$root/$p1_prefix") {
> + WARN("Patch prefix '$p1_prefix' exists. Is it maybe a p0-patch?\n");
> + }
>
> if ($realfile =~ m@^include/asm/@) {
> ERROR("do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");

Looks reasonable. Committed this with a few mods to my tree. Will be
in the next batch of updates.

-apw


\
 
 \ /
  Last update: 2008-11-12 14:59    [W:0.081 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site