Messages in this thread | | | Date | Wed, 12 Nov 2008 14:07:14 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 0/2] unlikely profiler and tracer |
| |
* Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Wed, 12 Nov 2008, Ingo Molnar wrote: > > * Steven Rostedt <rostedt@goodmis.org> wrote: > > > > > Ingo, > > > > > > The following patches are in: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git > > > > > > branch: tip/devel > > > > > > Steven Rostedt (2): > > > trace: profile likely and unlikely annotations > > > ftrace: unlikely annotation tracer > > > > i've created a new topic branch for this tracer: > > tip/tracing/branch-tracer, and applied your patches to that branch. > > Good idea, > > This profiler is very useful, but also very intrusive. I would like > it to get a broader audience for testing.
two more small details i noticed:
- does it do proper self-test? It doesnt seem so at first sight.
- i'd suggest a rename patch that does UNLIKELY_PROFILE => BRANCH_PROFILING.
[ 'to profile' is the verb we use generally (it's a noun too but we tend to use 'profiling' for that in other places of the kernel) - so we already have CONFIG_PROFILING, etc. ]
Ingo
| |