lkml.org 
[lkml]   [2008]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ttusb-budget: make it depend on PCI
From
Date
Arnd Bergmann <arnd@arndb.de> writes:

> On Wednesday 12 November 2008, Mike Frysinger wrote:
>> From:
>> Mike Frysinger <vapier@gentoo.org>
>> To:
>> v4l-dvb-maintainer@linuxtv.org, linux-dvb@linuxtv.org, Holger Waechtler <holger@convergence.de>
>> CC:
>> Mauro Carvalho Chehab <mchehab@infradead.org>, linux-kernel@vger.kernel.org
>> Date:
>> Today 13:00:18
>>  
>> Since dvb-ttusb-budget.c relies on pci_alloc_consistent and
>> pci_free_consistent, make it depend on PCI in Kconfig.
>>
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> Shouldn't you just convert it (trivially) to dma_alloc_coherent and
> dma_alloc_coherent?

Unless it really needs to use the 16MB DMA zone (which I doubt
especially for USB devices) then it should not call either with a NULL
device argument.

-Andi

--
ak@linux.intel.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-11-12 13:57    [W:0.045 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site