Messages in this thread | | | Date | Tue, 11 Nov 2008 18:37:46 +1000 | From | "Dave Airlie" <> | Subject | Re: [git pull] drm fixes for 2.6.27-rc5 |
| |
On Tue, Nov 11, 2008 at 6:29 PM, Andrew Morton <akpm@linux-foundation.org> wrote: > On Tue, 11 Nov 2008 08:15:26 +0000 (GMT) Dave Airlie <airlied@linux.ie> wrote: > >> commit 78538bf14995a136c2d9a22159ada49937359119 >> Author: Dave Airlie <airlied@linux.ie> >> Date: Tue Nov 11 17:56:16 2008 +1000 >> >> drm/radeon: map registers at load time >> >> Now that the radeon driver has suspend/resume functions, it needs to map its >> registers at load time or it will likely crash if a suspend operation occurs >> before the driver has been initialized. >> >> This patch moves the register mapping code from firstopen to load and makes >> the mapping into a _DRM_DRIVER one so that the core won't remove it at >> lastclose time. > > Does this make the below patch obsolete?
Yes please drop this, the correct fix is the one Jesse posted + a fix on top of it I made in the same patch.
>> Fixes (at least partially) kernel bz #11891. > > A little thing: there are (or used to be) people who troll commits for > bugzilla reports to close off. I've adopted the convention of > indicating bugzilla reports via their full URL to make those efforts > easier and to increase their accuracy. >
Cool will try that in future.
Dave.
| |