lkml.org 
[lkml]   [2008]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: patch md-linear-fix-a-division-by-zero-bug-for-very-small-arrays.patch added to 2.6.27-stable tree
On Wed, Nov 12, 2008 at 09:46:36AM +1100, NeilBrown wrote:
> On Wed, November 12, 2008 9:28 am, Stefan Lippers-Hollmann wrote:
> > Hi
> >
> > On Dienstag, 11. November 2008, gregkh@suse.de wrote:
>
> >>
> >> --- a/drivers/md/linear.c
> >> +++ b/drivers/md/linear.c
> >> @@ -157,6 +157,8 @@ static linear_conf_t *linear_conf(mddev_
> >>
> >> min_spacing = conf->array_sectors / 2;
> >> sector_div(min_spacing, PAGE_SIZE/sizeof(struct dev_info *));
> >> + if (min_sectors == 0)
> >> + min_sectors = 1;
> >>
> >> /* min_spacing is the minimum spacing that will fit the hash
> >> * table in one PAGE. This may be much smaller than needed.
> >
> > drivers/md/linear.c: In function 'linear_conf':
> > drivers/md/linear.c:160: error: 'min_sectors' undeclared (first use in
> > this function)
> > drivers/md/linear.c:160: error: (Each undeclared identifier is reported
> > only once
> > drivers/md/linear.c:160: error: for each function it appears in.)
> > make[5]: *** [drivers/md/linear.o] Error 1
> > make[4]: *** [drivers/md] Error 2
> > make[4]: *** Waiting for unfinished jobs....
> >
> > This one obviously depends on:
> >
> > commit 23242fbb470ff4c8c4d41f178832cf1929273d7d
> > Author: Andre Noll <maan@systemlinux.org>
> > Date: Mon Oct 13 11:55:12 2008 +1100
> >
> > md: linear.c: Make two local variables sector-based.
> >
> > which in turn depends on previous changes.
>
> Yes, but only syntactically, not semantically.
>
> In 2.6.27, it needs to be
> if (min_spacing == 0)
> min_spacing = 1;

Thanks, I've adjusted the patch to look like this instead.

greg k-h


\
 
 \ /
  Last update: 2008-11-12 00:47    [W:0.038 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site