lkml.org 
[lkml]   [2008]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] for account_group_exec_runtime(), make sure ->signal can't be freed under rq->lock
From
Date
On Tue, 2008-11-11 at 11:35 +0100, Ingo Molnar wrote:
> * Oleg Nesterov <oleg@redhat.com> wrote:
> > The patch is ugly, but I don't see the better fix for now. Needs the
> > review from Peter/Ingo.
> this is indeed too ugly, and if we do it we'll get both this ugliness
> and the CPU loop upstream forever. Frank, if you dont have time to fix
> this code, then i guess the best thing is to do the full revert that
> Peter sent.

Well, at the moment I'm up to my armpits in alligators. That said,
we're going to have to pull in this code regardless, ugliness and all,
since we're guaranteed to run into the soft lockup bug otherwise. This
means that I'll have strong incentive to come back and readdress the fix
to remove the ugliness and address Peter's concerns. I have no idea
when that will be, however.
--
Frank Mayhar <fmayhar@google.com>
Google, Inc.



\
 
 \ /
  Last update: 2008-11-11 18:13    [W:1.047 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site