Messages in this thread | | | Date | Tue, 11 Nov 2008 10:31:00 +0530 | From | Balbir Singh <> | Subject | Re: [RFC][mm] [PATCH 4/4] Memory cgroup hierarchy feature selector (v2) |
| |
KAMEZAWA Hiroyuki wrote: > On Sat, 08 Nov 2008 14:41:13 +0530 > Balbir Singh <balbir@linux.vnet.ibm.com> wrote: > >> Don't enable multiple hierarchy support by default. This patch introduces >> a features element that can be set to enable the nested depth hierarchy >> feature. This feature can only be enabled when the cgroup for which the >> feature this is enabled, has no children. >> >> Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com> >> --- >> > IMHO, permission to this is not enough. > > I think following is sane way. > == > When parent->use_hierarchy==1. > my->use_hierarchy must be "1" and cannot be tunrned to be "0" even if no children. > When parent->use_hierarchy==0 > my->use_hierarchy can be either of "0" or "1". > this value can be chagned if we don't have children > ==
Sounds reasonable, will fix in v3.
-- Balbir
| |