lkml.org 
[lkml]   [2008]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][mm] [PATCH 4/4] Memory cgroup hierarchy feature selector (v2)
KAMEZAWA Hiroyuki wrote:
> On Sat, 08 Nov 2008 14:41:13 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>
>> Don't enable multiple hierarchy support by default. This patch introduces
>> a features element that can be set to enable the nested depth hierarchy
>> feature. This feature can only be enabled when the cgroup for which the
>> feature this is enabled, has no children.
>>
>> Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>
>> ---
>>
> IMHO, permission to this is not enough.
>
> I think following is sane way.
> ==
> When parent->use_hierarchy==1.
> my->use_hierarchy must be "1" and cannot be tunrned to be "0" even if no children.
> When parent->use_hierarchy==0
> my->use_hierarchy can be either of "0" or "1".
> this value can be chagned if we don't have children
> ==

Sounds reasonable, will fix in v3.

--
Balbir


\
 
 \ /
  Last update: 2008-11-11 06:03    [W:0.114 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site