Messages in this thread | | | Date | Mon, 10 Nov 2008 10:01:18 +0100 | From | Eric Dumazet <> | Subject | Re: [git pull] OProfile fixes for v2.6.28 |
| |
Andi Kleen a écrit : > Eric Dumazet <dada1@cosmosbay.com> writes: > >> diff --git a/arch/x86/oprofile/op_model_ppro.c b/arch/x86/oprofile/op_model_ppro.c >> index 3f1b81a..716d26f 100644 >> --- a/arch/x86/oprofile/op_model_ppro.c >> +++ b/arch/x86/oprofile/op_model_ppro.c >> @@ -69,7 +69,7 @@ static void ppro_setup_ctrs(struct op_msrs const * const msrs) >> int i; >> >> if (!reset_value) { >> - reset_value = kmalloc(sizeof(unsigned) * num_counters, >> + reset_value = kmalloc(sizeof(reset_value[0]) * num_counters, > > Thanks for tracking this down. > > But that still doesn't explain why 2.6.27 fails too?
No :(
In fact 2.6.24 fails too. Oprofile never worked correctly.
Still investigating...
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |