lkml.org 
[lkml]   [2008]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v42] proc: add /proc/*/stack (was Re: linux-next: proc tree build failure)

* Alexey Dobriyan <adobriyan@gmail.com> wrote:

> > Alexey, would you like to carry them for v2.6.29? They are in a
> > separate tree here, the pull coordinates are below.
> >
> > Please preserve the sha1's (do not rebase/cherry-pick, etc.) so
> > that i can carry it too without causing confusion.
>
> Sorry, I can't.

hm, git pull did not work?

> It's two commits, PROC_BLOCK_SIZE moving chunk is now unneeded,
> because seqfiles are in use, grabbing tasklist_lock for protection
> from task dissapearing is unneeded -- proc_single_show() pins
> task_struct, entry is added only to tgid table.

hm, but these are small differences that do not impact bisectability,
you could have done it ontop of what we have, instead of a rebase? Oh
well.

> So, here is final version:

thanks!

I've rebased tip/core/stacktrace and zapped the history of the old
commits from that branch. Would have been really nice to preserve the
sha1 space and not force a rebase, like Linus is requesting it so
frequently.

Had you done a git pull from me i could have carried this feature too
without creating conflicts, instead of it disappearing in your tree
for months and being hidden up until v2.6.29. This whole 'distributed
development' stuff that's all the rage ;-)

i also regenerated tip-core, so it should now be conflict-free in
Stephen's tree too. (Stephen, please holler if you still get
conflicts)

Ingo


\
 
 \ /
  Last update: 2008-11-10 09:51    [W:0.026 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site