lkml.org 
[lkml]   [2008]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] add /proc/pid/stack to dump task's stack trace
On Fri, 7 Nov 2008 10:29:02 +0100
Ingo Molnar <mingo@elte.hu> wrote:

> > I guess the 0400 mode on that file will suffice...
>
> correct, 0400 is used already in the present patch:
>
> phoenix:~> cat /proc/1/stack
> cat: /proc/1/stack: Permission denied
>
> but that is _not_ enough, it should be narrowed even more, to the
> boundaries that i pointed out in my first review feedback mail, and
> which is not implemented yet:
>
> 1) only root should be allowed to do this - i.e. file needs to be
> root-owned.
>
> 2) there also needs to be a .config entry for folks to be able to
> turn it off altogether - just like folks can turn off sysrq-t
> dumping via the .config.

Doing the above is desirable for another reason: given our rather
erratic history with the stack backtracer, this /proc file is possibly
a convenient way of oopsing the kernel, sending of off into la-la-land, etc.



\
 
 \ /
  Last update: 2008-11-11 00:57    [W:0.073 / U:0.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site