Messages in this thread Patch in this message | | | Date | Sat, 1 Nov 2008 22:12:50 +0300 | From | Alexey Dobriyan <> | Subject | Re: [PATCH] el3_common_init() should be __devinit, not __init |
| |
On Sat, Nov 01, 2008 at 06:20:19PM +0000, Al Viro wrote: > -static int __init el3_common_init(struct net_device *dev) > +static int __devinit el3_common_init(struct net_device *dev)
Al, here is much better patch:
--- a/include/linux/init.h +++ b/include/linux/init.h @@ -83,20 +83,20 @@ #define __exit __section(.exit.text) __exitused __cold /* Used for HOTPLUG */ -#define __devinit __section(.devinit.text) __cold -#define __devinitdata __section(.devinit.data) -#define __devinitconst __section(.devinit.rodata) -#define __devexit __section(.devexit.text) __exitused __cold -#define __devexitdata __section(.devexit.data) -#define __devexitconst __section(.devexit.rodata) +#define __devinit __cold +#define __devinitdata +#define __devinitconst +#define __devexit __exitused __cold +#define __devexitdata +#define __devexitconst /* Used for HOTPLUG_CPU */ -#define __cpuinit __section(.cpuinit.text) __cold -#define __cpuinitdata __section(.cpuinit.data) -#define __cpuinitconst __section(.cpuinit.rodata) -#define __cpuexit __section(.cpuexit.text) __exitused __cold -#define __cpuexitdata __section(.cpuexit.data) -#define __cpuexitconst __section(.cpuexit.rodata) +#define __cpuinit __cold +#define __cpuinitdata +#define __cpuinitconst +#define __cpuexit __cold +#define __cpuexitdata +#define __cpuexitconst /* Used for MEMORY_HOTPLUG */ #define __meminit __section(.meminit.text) __cold @@ -115,13 +115,13 @@ #define __INITRODATA .section ".init.rodata","a" #define __FINITDATA .previous -#define __DEVINIT .section ".devinit.text", "ax" -#define __DEVINITDATA .section ".devinit.data", "aw" -#define __DEVINITRODATA .section ".devinit.rodata", "a" +#define __DEVINIT +#define __DEVINITDATA +#define __DEVINITRODATA -#define __CPUINIT .section ".cpuinit.text", "ax" -#define __CPUINITDATA .section ".cpuinit.data", "aw" -#define __CPUINITRODATA .section ".cpuinit.rodata", "a" +#define __CPUINIT +#define __CPUINITDATA +#define __CPUINITRODATA #define __MEMINIT .section ".meminit.text", "ax" #define __MEMINITDATA .section ".meminit.data", "aw"
| |