lkml.org 
[lkml]   [2008]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: splice vs O_APPEND
From
Date
On Thu, 9 Oct 2008, Linus Torvalds wrote:
> I do wonder if we shouldn't just do this in rw_verify_area(). The whole
> reason for that function is that we used to have all those flock checks
> etc spread out all over, and some path would inevitably just miss one
> check or another. It's kind of stupid to expect low-level filesystems to
> do the IS_APPEND/IS_IMMUTABLE checks.

Do we expect them? I thought we don't care if it's marked immutable
or append-only after the file has been opened, same as with normal
permissions.

> Comments?

Your patch still ignores O_APPEND, is that what we want? It sounds
sort of strange. pwrite() for example honors O_APPEND and ignores the
position, AFAICS.

Miklos


\
 
 \ /
  Last update: 2008-10-09 18:07    [W:0.170 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site