Messages in this thread | | | Date | Wed, 8 Oct 2008 09:15:53 +0200 (CEST) | From | Geert Uytterhoeven <> | Subject | Re: [RFC] Normalizing byteorder/unaligned access API |
| |
On Tue, 7 Oct 2008, Harvey Harrison wrote: > On Tue, 2008-10-07 at 17:33 -0600, Matthew Wilcox wrote: > > On Tue, Oct 07, 2008 at 03:39:25PM -0700, Harvey Harrison wrote: > > > As an example, in the write command handling in achba.c, a patch similar to the following > > > (assumes the existence of a __be24 type somewhere): > > > > What type could be defined to be '__be24'? Would > > > > typedef struct { > > unsigned char data[3]; > > } __be24; > > __packed
I don't think __packed would help here, as alignment(struct) == max(alignment(struct member)) == alignment(char).
Don't you want the __packed on the structure that embeds the __be24?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |