Messages in this thread | | | Date | Wed, 8 Oct 2008 18:31:25 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] documentation: explain memory barriers |
| |
On Wed, 08 Oct 2008 21:17:58 -0400 Chris Snook <csnook@redhat.com> wrote:
> Randy Dunlap wrote: > > On Wed, 1 Oct 2008 22:54:04 -0700 Andrew Morton wrote: > > > >> This sequence is repeated three or four times and should be pulled out > >> into a well-commented function. That comment should explain the logic > >> behind the use of these barriers, please. > > > > and on 2008-OCT-08 Ben Hutchings wrote: > > > >> All memory barriers need a comment to explain why and what they're doing.
I approve this message.
> Seriously? When a barrier is used, it's generally self-evident what > it's doing.
fs/buffer.c:sync_buffer(). Have fun.
| |