lkml.org 
[lkml]   [2008]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] sky2: Fix recent WOL regression
From
From: "Rafael J. Wysocki" <rjw@sisk.pl>
Date: Thu, 9 Oct 2008 00:55:55 +0200

> On Friday, 3 of October 2008, Stephen Hemminger wrote:
> > On Thu, 2 Oct 2008 23:39:33 +0200
> > "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> >
> > > From: Rafael J. Wysocki <rjw@sisk.pl>
> > >
> > > sky2: Fix recent WOL regression
> > >
> > > Since dev->power.should_wakeup bit is used by the PCI core to
> > > decide whether the device should wake up the system from sleep
> > > states, set/unset this bit whenever WOL is enabled/disabled using
> > > sky2_set_wol() (this fixes a regression from 2.6.26 on the Tino's
> > > machine).
> > >
> > > Remove an open-coded reference to the standard PCI PM registers that
> > > is not used any more.
> > >
> > > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > > Reported-by: Tino Keitel <tino.keitel@gmx.de>
> > > ---
> >
> > Acked-by: Stephen Hemminger <shemminger@vyatta.com>
> >
> > Thanks for fixing this.
>
> Can you please include this patch into your next push for Jeff?
>
> It seems to have been overlooked.

I missed this ACK but I did add the patch to my tree as you
can see from another email of mine.


\
 
 \ /
  Last update: 2008-10-09 01:15    [W:0.038 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site