Messages in this thread | | | Date | Wed, 8 Oct 2008 10:07:43 -0400 (EDT) | From | Alan Stern <> | Subject | Re: PATCH 10/4]linux-usb: To support more Huawei data card product IDs, fix kernel 2.6.27-rc7 |
| |
On Wed, 8 Oct 2008, fangxiaozhi 00110321 wrote:
> --- linux-2.6.27-rc7-orig/drivers/usb/storage/initializers.c 2008-09-22 06:29:55.000000000 +0800 > +++ linux-2.6.27-rc7/drivers/usb/storage/initializers.c 2008-09-24 12:04:40.000000000 +0800 > @@ -95,11 +95,11 @@ int usb_stor_huawei_e220_init(struct us_ > { > int result; > > - us->iobuf[0] = 0x1; > + us->iobuf[0] = 0x0; > result = usb_stor_control_msg(us, us->send_ctrl_pipe, > USB_REQ_SET_FEATURE, > USB_TYPE_STANDARD | USB_RECIP_DEVICE, > - 0x01, 0x0, us->iobuf, 0x1, 1000); > + 0x01, 0x0, us->iobuf, 0x0, 1000);
If you insist on doing this, you should at least do it right.
Take out entirely the line that sets usb->iobuf[0], and replace us->iobuf in the line above with NULL. You can also replace your foolish-looking 0x0 with a plain simple 0 -- after all, 0 is 0 whether in base 10 or base 16.
Alan Stern
| |