lkml.org 
[lkml]   [2008]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRE: [PATCH V2] btsdio: fix tx error path
    Date
    From


    >-----Original Message-----
    >From: Marcel Holtmann [mailto:marcel@holtmann.org]
    >Sent: Monday, October 06, 2008 2:02 PM
    >To: Winkler, Tomas
    >Cc: linux-bluetooth@vger.kernel.org; linux-kernel@vger.kernel.org
    >Subject: Re: [PATCH V2] btsdio: fix tx error path
    >
    >Hi Tomas,
    >
    >> This patch fixes accumulating of the header
    >> in case packet was requeued in the error path.
    >>
    >> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
    >> Cc: Marcel Holtmann <marcel@holtmann.org>
    >> ---
    >> drivers/bluetooth/btsdio.c | 1 +
    >> 1 files changed, 1 insertions(+), 0 deletions(-)
    >>
    >> diff --git a/drivers/bluetooth/btsdio.c b/drivers/bluetooth/btsdio.c
    >> index 58630cc..c422e89 100644
    >> --- a/drivers/bluetooth/btsdio.c
    >> +++ b/drivers/bluetooth/btsdio.c
    >> @@ -91,6 +91,7 @@ static int btsdio_tx_packet(struct btsdio_data
    *data,
    >struct sk_buff *skb)
    >>
    >> err = sdio_writesb(data->func, REG_TDAT, skb->data, skb->len);
    >> if (err < 0) {
    >> + skb_pull(skb, 4);
    >> sdio_writeb(data->func, 0x01, REG_PC_WRT, NULL);
    >> return err;
    >> }
    >
    >thanks, but I already fixed that one manually in my tree :)

    Yeah I guessed that, resubmitted just for the protocol.
    Tomas

    ---------------------------------------------------------------------
    Intel Israel (74) Limited

    This e-mail and any attachments may contain confidential material for
    the sole use of the intended recipient(s). Any review or distribution
    by others is strictly prohibited. If you are not the intended
    recipient, please contact the sender and delete all copies.



    \
     
     \ /
      Last update: 2008-10-06 14:09    [W:4.060 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site