Messages in this thread | | | Date | Sun, 05 Oct 2008 06:52:49 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH 1/6] Hibernation: Introduce system_entering_hibernation |
| |
Alan Cox wrote: >> Hm, I'm not sure what you mean exactly, but the point is to blacklist the >> on-board controllers only and a devfn of the controller is needed for that, >> or a part of it (like the slot number I'm using). Could that be done above >> the driver level? > > It can be done in one place via the libata core code I think rather than > in each driver. Might need to be a helper function but you'd at least > remove all the duplication.
I think it's better to keep the list in each LLD but having a helper in libata-core would be nice.
Thanks.
-- tejun
| |