lkml.org 
[lkml]   [2008]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] ftrace: nmi safe code modification

* Andrew Morton <akpm@linux-foundation.org> wrote:

> > + /* make sure NMIs see the cleared bit */
> > + smp_mb();
> > +
> > + wait_for_nmi();
> > +
> > + return mod_code_status;
> > +}
>
> I guess the weakness here is that the code will only allow a single
> contiguous hunk of text to be modified. One could envisage
> situations where two or more separate areas of memory need to be
> modified atomically/together.
>
> I guess we can cross that bridge when we fall off it.

yeah - the whole 'transaction' concept can be extended easily, in just
one place.

Not that i think that it would really be useful to go beyond the
current (target,len) abstraction - the less complex code patching is
done, the better.

Ingo


\
 
 \ /
  Last update: 2008-10-30 21:41    [W:0.051 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site