Messages in this thread | | | Date | Thu, 30 Oct 2008 20:25:41 +0100 | From | Jiri Slaby <> | Subject | Re: hid: struct device - replace bus_id with dev_name(), dev_set_name() |
| |
Kay Sievers napsal(a): > switch over to the new api, which will remove the 20 bytes array > and does no longer have a size limitation.
Cool!
> From: Kay Sievers <kay.sievers@vrfy.org> > Subject: hid: struct device - replace bus_id with dev_name(), dev_set_name() > > CC: Jiri Kosina <jkosina@suse.cz> > Acked-by: Greg Kroah-Hartman <gregkh@suse.de> > Signed-Off-By: Kay Sievers <kay.sievers@vrfy.org> > --- > > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > index 721a36d..73ccc37 100644 > --- a/drivers/hid/hid-core.c > +++ b/drivers/hid/hid-core.c > @@ -1573,9 +1573,8 @@ int hid_add_device(struct hid_device *hdev) > if (hid_ignore(hdev)) > return -ENODEV; > > - /* XXX hack, any other cleaner solution < 20 bus_id bytes? */ > - sprintf(hdev->dev.bus_id, "%04X:%04X:%04X.%04X", hdev->bus, > - hdev->vendor, hdev->product, atomic_inc_return(&id)); > + dev_set_name(&hdev->dev, "%04X:%04X:%04X.%04X", hdev->bus, > + hdev->vendor, hdev->product, atomic_inc_return(&id));
Could you left the comment above to remind us about removing this ugly hack later when the new non-limited api will be used?
| |