Messages in this thread | | | Date | Fri, 3 Oct 2008 17:39:17 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH 2.6.27-rc8 5/6] e1000e: debug contention on NVM SWFLAG |
| |
On Fri, 3 Oct 2008, Linus Torvalds wrote:
> > The debugging message is racy anyway with respect to accessing > > nvm_owner, right? It should be done after the mutex has been > > succesfully acquired. > It's done that way on purpose - to see who _could_ be racing.
I know. I just wanted to point out that we probably don't want the patch in 2.6.27 in this form, users wouldn't like to have warning in their logs every time mutex is not acquired on a first attempt :)
We are currently running reproduction tests on affected machines to verify that this patch really fixes the root cause of this whole e1000e saga.
-- Jiri Kosina SUSE Labs
| |