Messages in this thread | | | Subject | Re: [PATH -mm -v2] Fix a race condtion of oops_in_progress | From | Huang Ying <> | Date | Thu, 30 Oct 2008 10:02:59 +0800 |
| |
Hi, Chris,
On Wed, 2008-10-29 at 08:51 -0600, Chris Snook wrote: > Huang Ying wrote: > > Fix a race condition accessing oops_in_progress. Which may be changed on > > multiple CPU simultaneously, but it is changed via non-atomic operation > > ++/--. This patch changes the definition of oops_in_process from int to > > atomic_t, and accessing method to atomic operations. > > You also need barriers. I believe rmb() before atomic_read() and wmb() after > atomic_set() should suffice.
I don't think that is necessary. I haven't found there is particular consistent requirement about oops_in_progress.
Best Regards, Huang Ying
[unhandled content-type:application/pgp-signature] | |