lkml.org 
[lkml]   [2008]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subjectgpu: struct device - replace bus_id with dev_name(), dev_set_name()
    From
    Date
    This patch is part of a larger patch series which will remove
    the "char bus_id[20]" name string from struct device. The device
    name is managed in the kobject anyway, and without any size
    limitation, and just needlessly copied into "struct device".

    To set and read the device name dev_name(dev) and dev_set_name(dev)
    must be used. If your code uses static kobjects, which it shouldn't
    do, "const char *init_name" can be used to statically provide the
    name the registered device should have. At registration time, the
    init_name field is cleared, to enforce the use of dev_name(dev) to
    access the device name at a later time.

    We need to get rid of all occurrences of bus_id in the entire tree
    to be able to enable the new interface. Please apply this patch,
    and possibly convert any remaining remaining occurrences of bus_id.

    We want to submit a patch to -next, which will remove bus_id from
    "struct device", to find the remaining pieces to convert, and finally
    switch over to the new api, which will remove the 20 bytes array
    and does no longer have a size limitation.

    Thanks,
    Kay


    From: Kay Sievers <kay.sievers@vrfy.org>
    Subject: gpu: struct device - replace bus_id with dev_name(), dev_set_name()

    CC: Dave Airlie <airlied@redhat.com>
    Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-Off-By: Kay Sievers <kay.sievers@vrfy.org>
    ---


    diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c
    index 1611b9b..98a575c 100644
    --- a/drivers/gpu/drm/drm_sysfs.c
    +++ b/drivers/gpu/drm/drm_sysfs.c
    @@ -165,7 +165,7 @@ int drm_sysfs_device_add(struct drm_minor *minor)
    minor->kdev.devt = minor->device;
    minor_str = "card%d";

    - snprintf(minor->kdev.bus_id, BUS_ID_SIZE, minor_str, minor->index);
    + dev_set_name(&minor->kdev, minor_str, minor->index);

    err = device_register(&minor->kdev);
    if (err) {



    \
     
     \ /
      Last update: 2008-10-30 02:27    [W:5.161 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site