Messages in this thread | | | Date | Mon, 27 Oct 2008 23:31:50 -0400 | From | "Mike Frysinger" <> | Subject | Re: [PATCH] linux/timex.h: cleanup for userspace |
| |
On Mon, Oct 27, 2008 at 11:28 PM, Andrew Morton wrote: > On Sun, 26 Oct 2008 06:37:31 -0400 Mike Frysinger wrote: >> Move all the kernel-specific defines and includes into the __KERNEL__ >> section so that they don't get leaked into userspace. > > checkpatch correctly instructs us to use linux/param.h, not asm/param.h.
i was just moving around existing code in an attempt to minimize possible breakage ;)
> --- a/include/linux/timex.h~linux-timexh-cleanup-for-userspace-checkpatch-fixes > +++ a/include/linux/timex.h > @@ -165,8 +165,8 @@ struct timex { > #ifdef __KERNEL__ > #include <linux/compiler.h> > #include <linux/types.h> > +#include <linux/param.h> > > -#include <asm/param.h> > #include <asm/timex.h> > > /* > _ > > seems Obviously Safe to me. Do you agree?
Acked-by: Mike Frysinger <vapier@gentoo.org> -mike -mike
| |