Messages in this thread | | | Date | Tue, 28 Oct 2008 11:06:35 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH 2.6.28-rc2] sata_promise: proper hardreset |
| |
Hello, Mikael.
Mikael Pettersson wrote: > +static int pdc_pata_hardreset(struct ata_link *link, unsigned int *class, > + unsigned long deadline) > +{ > + pdc_reset_port(link->ap); > + return 0; > +}
You either need to return -EAGAIN here to ask for follow-up SRST or override softreset. I think pdc_reset_port() doesn't actually reset the ATA channel, right? In that case, the latter would be the correct thing to do.
Thanks.
-- tejun
| |