lkml.org 
[lkml]   [2008]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6.28-rc2] sata_promise: proper hardreset
Hello, Mikael.

Mikael Pettersson wrote:
> +static int pdc_pata_hardreset(struct ata_link *link, unsigned int *class,
> + unsigned long deadline)
> +{
> + pdc_reset_port(link->ap);
> + return 0;
> +}

You either need to return -EAGAIN here to ask for follow-up SRST or
override softreset. I think pdc_reset_port() doesn't actually reset the
ATA channel, right? In that case, the latter would be the correct thing
to do.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2008-10-28 03:09    [W:0.036 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site