Messages in this thread | | | Date | Mon, 27 Oct 2008 22:52:33 +0100 | From | Bernhard Walle <> | Subject | Re: [PATCH] [WATCHDOG] Fix kdump when using hpwdt |
| |
Hi Wim,
* Wim Van Sebroeck [2008-10-27 20:30]:
> > -module_param(allow_kdump, int, 0); > > +module_param(allow_kdump, int, 1); > > MODULE_PARM_DESC(allow_kdump, "Start a kernel dump after NMI occurs"); > > the syntax is: #define module_param(name, type, perm) > perm sets the visibility in sysfs: 000 means it's not there, > read bits mean it's readable, write bits mean it's writable. > > perm is not the default value for the integer but a file permission attribute.
Yeah, thanks for spotting that. I was a bit in hurry while creating the patch ...
I'll come up with an updated patch with the suggestions from Vivek. Probably tomorrow.
Regards, Bernhard -- Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development
| |