Messages in this thread | | | Subject | Re: [PATCH] ibmpex: trivial endian annotation in extract_data helper | From | Harvey Harrison <> | Date | Mon, 27 Oct 2008 12:26:06 -0700 |
| |
On Mon, 2008-10-27 at 11:32 -0700, Darrick J. Wong wrote: > On Fri, Oct 24, 2008 at 04:44:58PM -0700, Harvey Harrison wrote: > > This helper is used in few enough locations that open-coding it > > at the call sites may be better than the helper. > > I'm not sure how this comment relates to the diff. >
I was referring to the extract_data helper inline, it's only used ~5 times and doesn't add much (IMO) over just opencoding it.
Cheers,
Harvey
| |