Messages in this thread | | | Date | Mon, 27 Oct 2008 07:38:02 -0700 | From | Mike Travis <> | Subject | Re: [PATCH 1/1] SGI X86 UV: Provide a System Activity Indicator driver |
| |
Ingo Molnar wrote: ... > > Please send the cpu_idle() cleanup patch separately. > > Another minor thing i noticed: > > @@ -130,7 +140,9 @@ struct uv_hub_info_s { > unsigned char blade_processor_id; > unsigned char m_val; > unsigned char n_val; > + struct uv_scir_s scir; > > please align the new field vertically, like they were aligned before - > by adding another tab to the whole lineup. (This will also make it > appear nicer when viewed together with followup definitions below this > section)
Ok, will do, thanks!
Mike
| |