lkml.org 
[lkml]   [2008]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: staging: me4000: remove duplicated #include's
On Sun, Oct 26, 2008 at 5:33 PM, Adrian Bunk <bunk@kernel.org> wrote:
> On Mon, Oct 20, 2008 at 02:18:22PM -0700, Greg KH wrote:
>> On Sat, Oct 18, 2008 at 11:52:15AM +0800, Huang Weiyi wrote:
>> > Removed duplicated #include's in drivers/staging/me4000/me4000.c
>> > asm/uaccess.h
>> > linux/fs.h
>> >
>> > Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
>> >
>> > diff --git a/drivers/staging/me4000/me4000.c b/drivers/staging/me4000/me4000.c
>> > index 862dd7f..90de6f0 100644
>> > --- a/drivers/staging/me4000/me4000.c
>> > +++ b/drivers/staging/me4000/me4000.c
>> > @@ -30,7 +30,6 @@
>> > #include <asm/uaccess.h>
>> > #include <linux/errno.h>
>> > #include <linux/delay.h>
>> > -#include <linux/fs.h>
>> > #include <linux/mm.h>
>> > #include <linux/unistd.h>
>> > #include <linux/list.h>
>> > @@ -39,7 +38,6 @@
>> > #include <linux/poll.h>
>> > #include <linux/vmalloc.h>
>> > #include <asm/pgtable.h>
>> > -#include <asm/uaccess.h>
>> > #include <linux/types.h>
>> >
>> > #include <linux/slab.h>
>>
>> Hm, this doesn't apply anymore as some cleanups went in that should have
>> just made this not needed.
>>
>> But if you have a script I can run somewhere to verify it, I'd
>> appreciate it.
>
> linux-2.6$ make help | grep include
> includecheck - Check for duplicate included header files
> linux-2.6$

Is there a way to get this to just check in a user-specified
directory? I didn't see any options for that and adding
M=drivers/staging didn't help.

>
>> thanks,
>>
>> greg k-h
>
> cu
> Adrian
>
> --
>
> "Is there not promise of rain?" Ling Tan asked suddenly out
> of the darkness. There had been need of rain for many days.
> "Only a promise," Lao Er said.
> Pearl S. Buck - Dragon Seed
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>


\
 
 \ /
  Last update: 2008-10-26 22:43    [W:0.067 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site