Messages in this thread | | | Subject | Re: [PATCH] ubifs: endian handling fixes and annotations | From | Harvey Harrison <> | Date | Sun, 26 Oct 2008 11:44:42 -0700 |
| |
On Sun, 2008-10-26 at 15:22 +0200, Artem Bityutskiy wrote: > On Sat, 2008-10-25 at 11:52 -0700, Harvey Harrison wrote: > > > > fs/ubifs/sb.c:300:19: warning: incorrect type in assignment (different base types) > > > > fs/ubifs/sb.c:300:19: expected restricted __le64 [usertype] ctime_sec > > > > fs/ubifs/sb.c:300:19: got int [signed] [assigned] tmp > > > > fs/ubifs/sb.c:301:19: warning: incorrect type in assignment (different base types) > > > > fs/ubifs/sb.c:301:19: expected restricted __le64 [usertype] mtime_sec > > > > fs/ubifs/sb.c:301:19: got int [signed] [assigned] tmp > > > > > > ... snip ... > > > > > > thanks for the patch. It's shame we did not fix this ourselves. We did > > > run sparse before submitting UBIFS and did not see these warnings. > > > Probably sparse has been improved recently. Anyway, thank you, I'll look > > > closer at your patch and apply it to ubifs-2.6.git. > > > > > > > Run sparse with -D__CHECK_ENDIAN__ to see these warnings. > > Any idea why this is not default? >
Currently the build gets a bit verbose with this turned on, I've been working to get the noise down a bit, but perhaps still a ways off from turning this on.
Harvey
| |