lkml.org 
[lkml]   [2008]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PULL] module, param and stop_machine patches


On Sun, 26 Oct 2008, Rusty Russell wrote:
>
> Thanks, Heiko tracked this down; he's probably sleeping now but Hugh and Walt
> reported this fixes it for them and it makes sense.

I'm not seeing any "tracked it down".

Yes, it moves it back to its old place, but doesn't say why the new one
didn't work.

And it then mixes things up with 'stop_machine_init()' mess. Why does that
need to run so early?

Is there any reason why the real patch isn't just to make
'stop_machine_init' a 'core_initcall()' instead of 'early_initcall()'?

IOW, I don't think that patch is anything but a "hey, test if it works
with this". None of the changes or the problems are explained. Nor do I
see a sign-off from Heiko on it.

I also don't want to see more BUG_ON()'s there. Make them warnings or
something.

Linus


\
 
 \ /
  Last update: 2008-10-26 00:37    [W:0.066 / U:1.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site