Messages in this thread | | | Date | Fri, 24 Oct 2008 14:28:04 -0700 | From | Greg KH <> | Subject | Re: [patch 27/27] ath5k: fix suspend-related oops on rmmod |
| |
On Fri, Oct 24, 2008 at 10:36:24PM +0200, Elias Oltmanns wrote: > Greg KH <gregkh@suse.de> wrote: > > 2.6.27-stable review patch. If anyone has any objections, please let us > > know. > > > > ------------------ > > From: Bob Copeland <me@bobcopeland.com> > > > > commit 8bdd5b9c6bd53add260756b6673a0545fbdbba21 upstream > > > > Based on a patch by Elias Oltmanns, we call ath5k_init in resume even > > if we didn't previously open the device. Besides starting up the > > device unnecessarily, this also causes an oops on rmmod because > > mac80211 will not invoke ath5k_stop and softirqs are left running after > > the module has been unloaded. Add a new state bit, ATH_STAT_STARTED, > > to indicate that we have been started up. > > > > Reported-by: Toralf Förster <toralf.foerster@gmx.de> > > Signed-off-by: Elias Oltmanns <eo@nebensachen.de> > > Signed-off-by: Bob Copeland <me@bobcopeland.com> > > Signed-off-by: John W. Linville <linville@tuxdriver.com> > > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> > > I've done some more testing and I'm ashamed to say that this patch is > incomplete and does indeed introduce a regression itself. Having only > just sent the fix to John, I'm afraid this patch has to be deferred for > the next stable release since the required fix is not likely to hit > Linus' tree in time. Anyway, I'm adding my patch and the changelog entry > by way of explanation.
Ok, I've dropped this from the 2.6.27-stable queue now, thanks for letting me know.
greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |