lkml.org 
[lkml]   [2008]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[Cbe-oss-dev] [PATCH] Cell OProfile: Incorrect local array size in activate spu profiling function
    From
    Date

    The size of the pm_signal_local array should be equal to the
    number of SPUs being configured in the call. Currently, the
    array is of size 4 (NR_PHYS_CTRS) but being indexed by a for
    loop from 0 to 7 (NUM_SPUS_PER_NODE).

    Signed-off-by: Carl Love <carll@us.ibm.com>


    Index: Cell_kernel_10_24_2008/arch/powerpc/oprofile/op_model_cell.c
    ===================================================================
    --- Cell_kernel_10_24_2008.orig/arch/powerpc/oprofile/op_model_cell.c
    +++ Cell_kernel_10_24_2008/arch/powerpc/oprofile/op_model_cell.c
    @@ -830,7 +830,7 @@ static int calculate_lfsr(int n)
    static int pm_rtas_activate_spu_profiling(u32 node)
    {
    int ret, i;
    - struct pm_signal pm_signal_local[NR_PHYS_CTRS];
    + struct pm_signal pm_signal_local[NUM_SPUS_PER_NODE];

    /*
    * Set up the rtas call to configure the debug bus to



    \
     
     \ /
      Last update: 2008-10-24 20:51    [W:3.788 / U:0.688 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site