Messages in this thread | | | Date | Fri, 24 Oct 2008 12:33:15 -0200 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH] Check fops_get() return value |
| |
On Thu, 16 Oct 2008 15:28:00 +0200 Takashi Iwai <tiwai@suse.de> wrote:
> > > > old_fops = filp->f_op; > > filp->f_op = fops_get(&dev->driver->fops); > > + if (filp->f_op == NULL) { > > I think the more standard style is > > if (!file->fop) {
Yes. This seems a good cleanup to the patch.
> > Except for that minor issue, it looks good to me. > In any case, > > Acked-by: Takashi Iwai <tiwai@suse.de>
You have my ack also.
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Cheers, Mauro
| |