lkml.org 
[lkml]   [2008]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Check fops_get() return value
On Thu, 16 Oct 2008 15:28:00 +0200
Takashi Iwai <tiwai@suse.de> wrote:

> >
> > old_fops = filp->f_op;
> > filp->f_op = fops_get(&dev->driver->fops);
> > + if (filp->f_op == NULL) {
>
> I think the more standard style is
>
> if (!file->fop) {

Yes. This seems a good cleanup to the patch.

>
> Except for that minor issue, it looks good to me.
> In any case,
>
> Acked-by: Takashi Iwai <tiwai@suse.de>

You have my ack also.

Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>

Cheers,
Mauro


\
 
 \ /
  Last update: 2008-10-24 16:35    [W:0.027 / U:1.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site