lkml.org 
[lkml]   [2008]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing: fix a build error on alpha and m68k
2008/10/23 Ingo Molnar <mingo@elte.hu>:
> to answer the "is that a lockdep or just trace feature" question:
>
> trace-irqflags was first written by me for the (crude) ftrace-precursor
> latency tracer code in -rt, years ago. Then i reused it (and changed it
> alot) for upstream lockdep, two years ago. Then ftrace came in this year
> and reused it.
>
> so it's rather symbiotic ;-)
>
> So ... the tracers that rely on irqflags-tracing should definitely be
> limited to architectures that provide TRACE_IRQFLAGS. The core trace.c
> itself should probably not be restricted ... (and it should definitely
> build)
>
> Ingo
>

Ok, so perhaps it needs a kind of disambiguation between CONFIG_TRACE_IRQFLAGS
and CONFIG_TRACE_IRQFLAGS_SUPPORT :)

So, if those arch may not support irqflags, I should forget about
including linux/irqflags.h

But to let the core trace.c to be built for other types of tracing,
the best thing I see is to put some ifdef CONFIG_TRACE_IRQFLAGS on the
tracing_cpumask functions and structure, and actually on the creation
of this file.

No bad feelings about this solution?


\
 
 \ /
  Last update: 2008-10-23 19:09    [W:0.175 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site