Messages in this thread | | | Date | Thu, 23 Oct 2008 14:04:44 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 35/35] x86: clean up speedctep-centrino and reduce cpumask_t usage From: Rusty Russell <> |
| |
* Rusty Russell <rusty@rustcorp.com.au> wrote:
> On Thursday 23 October 2008 13:09:01 Mike Travis wrote: > > 1) The #ifdef CONFIG_HOTPLUG_CPU seems unnecessary these days. > > 2) The loop can simply skip over offline cpus, rather than creating a tmp > > mask. > > 3) set_mask is set to either a single cpu or all online cpus in a > > policy. Since it's just used for set_cpus_allowed(), any offline cpus in a > > policy don't matter, so we can just use cpumask_of_cpu() or the > > policy->cpus. > > Note that this cleanup stands alone; it's just that I read this code I > couldn't help but tidy it up. > > Ingo: do you just want to put this in your normal tree for sending to > Linus?
hm, cpufreq stuff belongs into davej's tree.
i skipped #34 and #35 for now, we can live without them, correct?
Ingo
| |