Messages in this thread | | | Date | Wed, 22 Oct 2008 09:19:09 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 8/15 v5] PCI: add boot options to reassign resources |
| |
* Yu Zhao <yu.zhao@intel.com> wrote:
> +static char *pci_assign_pio; > +static char *pci_assign_mmio; > + > +static int pcibios_bus_resource_needs_fixup(struct pci_bus *bus) > +{ > + int i; > + int type = 0; > + int domain, busnr; > + > + if (!bus->self) > + return 0; > + > + for (i = 0; i < 2; i++) { > + char *str = i ? pci_assign_pio : pci_assign_mmio; > + while (str && *str) {
please put a newline after local variable defitions.
> + for (i = 0; i < PCI_BUS_NUM_RESOURCES; i++) { > + struct resource *res = bus->resource[i]; > + if (!res)
ditto.
nice debug feature!
Ingo
| |