Messages in this thread | | | Date | Wed, 22 Oct 2008 10:00:45 +0100 | From | Alan Cox <> | Subject | Re: [PATCH 72/80] tty: fix up gigaset a bit |
| |
> additional test_bit(TTY_IO_ERROR, &tty->flags) would catch a case that > would otherwise be handled incorrectly?
Fiddling with tty->disc_data by hand probably currently does the right thing. I don't guarantee it will continue to do so after the BKL removal gets to ldisc setting.
> So I think removing the poll method is the right thing to do. If you > have no objections, I'll submit a patch doing just that. (Hoping to > still make it for the .28 merge window.)
If you really don't need the poll then it can go - for 2.6.29. The current code isn't wrong on a functional level it just returns unexpected results in the unplug case.
| |