lkml.org 
[lkml]   [2008]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] setup_per_zone_pages_min(): take zone->lock instead of zone->lru_lock

Thanks!

Tested-by: Yasunori Goto <y-goto@jp.fujitsu.com>


> From: Gerald Schaefer <gerald.schaefer@de.ibm.com>
>
> This replaces zone->lru_lock in setup_per_zone_pages_min() with zone->lock.
> There seems to be no need for the lru_lock anymore, but there is a need for
> zone->lock instead, because that function may call move_freepages() via
> setup_zone_migrate_reserve().
>
> Signed-off-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
>
> ---
> mm/page_alloc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-2.6/mm/page_alloc.c
> ===================================================================
> --- linux-2.6.orig/mm/page_alloc.c
> +++ linux-2.6/mm/page_alloc.c
> @@ -4207,7 +4207,7 @@ void setup_per_zone_pages_min(void)
> for_each_zone(zone) {
> u64 tmp;
>
> - spin_lock_irqsave(&zone->lru_lock, flags);
> + spin_lock_irqsave(&zone->lock, flags);
> tmp = (u64)pages_min * zone->present_pages;
> do_div(tmp, lowmem_pages);
> if (is_highmem(zone)) {
> @@ -4239,7 +4239,7 @@ void setup_per_zone_pages_min(void)
> zone->pages_low = zone->pages_min + (tmp >> 2);
> zone->pages_high = zone->pages_min + (tmp >> 1);
> setup_zone_migrate_reserve(zone);
> - spin_unlock_irqrestore(&zone->lru_lock, flags);
> + spin_unlock_irqrestore(&zone->lock, flags);
> }
>
> /* update totalreserve_pages */
>
>

--
Yasunori Goto




\
 
 \ /
  Last update: 2008-10-02 12:07    [W:1.556 / U:1.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site