Messages in this thread Patch in this message | | | From | Andres Freund <> | Subject | Re: [git pull] agp patches for 2.6.28-rc1. | Date | Mon, 20 Oct 2008 03:58:51 +0200 |
| |
Hi,
On Monday 20 October 2008 03:35:21 Keith Packard wrote: > On Mon, 2008-10-20 at 03:00 +0200, Andres Freund wrote: > > Hm. But still, there is at least one distribution (ubuntu intrepid) which > > will propably will ship 2.4.1 in its stable version soon (it seems > > unlikely that they will update to an unstable version just before an > > release). > We can backport the fix (it's tiny) to the 2.4 2D driver. Its basically only this, right?
diff --git a/src/i830_driver.c b/src/i830_driver.c index c1d61f4..eaf5d27 100644 --- a/src/i830_driver.c +++ b/src/i830_driver.c @@ -502,8 +502,8 @@ I830DetectMemory(ScrnInfoPtr pScrn) range = gtt_size + 4; /* new 4 series hardware has seperate GTT stolen with GFX stolen */ - if (IS_G4X(pI830)) - range = 0; + if (IS_G4X(pI830) || IS_GM45(pI830)) + range = 4; if (IS_I85X(pI830) || IS_I865G(pI830) || IS_I9XX(pI830)) { switch (gmch_ctrl & I855_GMCH_GMS_MASK) { Barring that I have absolutely idea about the code and all related stuff, do I see it correct, that this also will result in problems if the kernel doesn't have the related fix?
> > Which means, that this driver will get quite some spread... > > Is it accepted that the kernel abi breaks that radically/fast? > We tested a pile of hardware and didn't find any GM45s that worked, so > we assumed they were all broken and that fixing the bug wouldn't cause > any working configurations to stop working. Seems sensible from your side.
> We can hack up the kernel so the old X server just gets a WARN_ON > instead of breaking. This is a bit worrying though; the "fix" would let > user space continue to mis-program the hardware. If its really only a that small portion of hardware... At least the T500/T400 series, containing the same hw as mine, from Lenovo propably is not yet really wide spread (Laptop is 4weeks old or so and wasn't available before).
> My concern here is that a common failure mode with this bug was to lock > up the graphics hardware and require a reboot. Having the X server fail > to start and leave the system in text mode where new packages can be > installed seems like a better mode than making the system hang during > boot. Right.
Andres
| |