Messages in this thread | | | Date | Mon, 20 Oct 2008 00:09:22 +0200 | From | Jiri Slaby <> | Subject | Re: several messages |
| |
Jiri Kosina napsal(a): > On Sun, 19 Oct 2008, Jiri Slaby wrote: > >> +enum hid_type { >> + HID_TYPE_UNKNOWN = 0, >> + HID_TYPE_MOUSE, >> + HID_TYPE_KEYBOARD >> +}; >> + > > Do we really need the HID_TYPE_KEYBOARD at all? It's not used anywhere in > the code. I'd propose to add it when it is actually needed. I.e. have the > enum contain something like HID_TYPE_MOUSE HID_TYPE_OTHER for now, and add > whatever will become necessary in the future, what do you think?
I would use unknown rather than other, since on bluetooth mouse is unknown not other, if you don't mind?
Or did you mean tristate unknown, mouse and other?
Thanks for review.
| |