Messages in this thread | | | Date | Fri, 17 Oct 2008 20:17:33 +0600 | From | "Rakib Mullick" <> | Subject | Re: [PATCH] init: Properly placing noinline keyword. |
| |
On 10/17/08, Alexey Dobriyan <adobriyan@gmail.com> wrote: > On Fri, Oct 17, 2008 at 07:05:32PM +0600, Rakib Mullick wrote: > > Here, noinline keyword should be placed between storage class and type. > > > Why? Because, scripts/checkpatch.pl warned with following warning: ERROR: inline keyword should sit between storage class and type > > > > --- linux-2.6-stable.orig/init/main.c > > > +++ linux-2.6-stable/init/main.c > > > @@ -457,7 +457,7 @@ static void __init setup_command_line(ch > > * gcc-3.4 accidentally inlines this function, so use noinline. > > */ > > > > -static void noinline __init_refok rest_init(void) > > +static noinline void __init_refok rest_init(void) > > __releases(kernel_lock) > > { > > int pid; > > @@ -792,7 +792,7 @@ static void run_init_process(char *init_ > > /* This is a non __init function. Force it to be noinline otherwise gcc > > * makes it inline to init() and it becomes part of init.text section > > */ > > -static int noinline init_post(void) > > +static noinline int init_post(void) >
| |