Messages in this thread | | | Date | Thu, 16 Oct 2008 09:09:07 +0200 (CEST) | From | Geert Uytterhoeven <> | Subject | Re: [PATCH] SiS55x, another x86 CPU |
| |
On Thu, 16 Oct 2008, Hans Schou wrote: > On Wed, 15 Oct 2008, Geert Uytterhoeven wrote: > > On Wed, 15 Oct 2008, Andi Kleen wrote: > > > > If any CR/LF in your file you must have added them yourself. > > > > > > There were definitely CR/LFs in the patch attachment you sent. > > > And no my mailer doesn't add them. > > > > Interesting. I didn't see any CR/LFs neither, after exporting the > > attachment to a file (I'm using pine). > > As far as I could see, Pine does this: > > 1. If file has not extension like: .zip .jpg .exe, see it as ASCII > 2. Add CR/LF to the file > 3. Encode file as base64 > > On reception of the file: > > 1. Decode file as specified (in this case base64) > 2. If it looks like a text file, convert CR/LF to LF. > > > However, when doing a base64 decode on the raw attachment data, the > > CR/LFs did pop up. > > I think time is up for getting rid of Pine and there stupid license. I'll > check if "nail" can handle attachment correctly.
alpine?
But, why do you send patches as attachments in the first place? It's recommended to _not_ do that, for easier review. Pine can handle that fine since ages (I switched from elm to pine 13 or so years ago).
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |