Messages in this thread | | | Date | Thu, 16 Oct 2008 20:49:00 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH] Fix broken debug output reserve_region_with_split() |
| |
On Fri, 17 Oct 2008, Benjamin Herrenschmidt wrote: > > Ok, I'll wait for more comments before a respin to :-) I'm mostly > wondering whether to use fixed sized format rather than the current > variable size (and pad with zeros).
Sadly, I think that gcc warns if we were to support %08pR, so we can't pass down flags.
That said, I don't much like SPECIAL in the flags. We never do that thing. Doing a git grep for some range printouts, we tend to do things like
[%lx,%lx] [%x - %x] [%llx, %llx] [%016lx - %016lx] <%016llx-%016llx>
But using "0x%llx" or "%#llx" is very rare. It happens (notably drivers/pci/setup-res.c), but it's not common.
But it would be kind of nice to be able to do extended flags. Maybe we could do it with
%p04R
and the 04 would be parsed as flags, the same way we do %04x. And then if you want the 0x, you can use %p#08R..
Linus
| |