Messages in this thread Patch in this message | | | Subject | Re: [PATCH] Fix broken debug output reserve_region_with_split() | From | Benjamin Herrenschmidt <> | Date | Fri, 17 Oct 2008 14:06:31 +1100 |
| |
From: Linus Torvalds <torvalds@linux-foundation.org>
Implement %pR to print struct resource content
Add a %pR option to the kernel vsnprintf that prints the range of addresses inside a struct resource passed by pointer.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> ---
And this one has updated comments.
Index: linux-work/lib/vsprintf.c =================================================================== --- linux-work.orig/lib/vsprintf.c 2008-10-17 13:30:18.000000000 +1100 +++ linux-work/lib/vsprintf.c 2008-10-17 14:04:58.000000000 +1100 @@ -24,6 +24,7 @@ #include <linux/kernel.h> #include <linux/kallsyms.h> #include <linux/uaccess.h> +#include <linux/ioport.h> #include <asm/page.h> /* for PAGE_SIZE */ #include <asm/div64.h> @@ -550,18 +551,38 @@ static char *symbol_string(char *buf, ch #endif } +static char *resource_string(char *buf, char *end, struct resource *res, int field_width, int precision, int flags) +{ + /* room for the actual numbers, the two "0x", -, [, ] and the final zero */ + char sym[4*sizeof(resource_size_t) + 8]; + char *p = sym, *pend = sym + sizeof(sym); + + *p++ = '['; + p = number(p, pend, res->start, 16, -1, -1, SPECIAL | SMALL); + *p++ = '-'; + p = number(p, pend, res->end, 16, -1, -1, SPECIAL | SMALL); + *p++ = ']'; + *p = 0; + + return string(buf, end, sym, field_width, precision, flags); +} + /* * Show a '%p' thing. A kernel extension is that the '%p' is followed * by an extra set of alphanumeric characters that are extended format * specifiers. * - * Right now we just handle 'F' (for symbolic Function descriptor pointers) - * and 'S' (for Symbolic direct pointers), but this can easily be - * extended in the future (network address types etc). - * - * The difference between 'S' and 'F' is that on ia64 and ppc64 function - * pointers are really function descriptors, which contain a pointer the - * real address. + * Right now we handle: + * + * - 'F' For symbolic Function descriptor pointers + * - 'S' For Symbolic direct pointers), but this can easily be + * extended in the future (network address types etc). + * - 'R' For a struct resouce pointer, it prints the range of + * addresses (not the name nor the flags) + * + * Note: The difference between 'S' and 'F' is that on ia64 and ppc64 + * function pointers are really function descriptors, which contain a + * pointer the real address. */ static char *pointer(const char *fmt, char *buf, char *end, void *ptr, int field_width, int precision, int flags) { @@ -571,6 +592,8 @@ static char *pointer(const char *fmt, ch /* Fallthrough */ case 'S': return symbol_string(buf, end, ptr, field_width, precision, flags); + case 'R': + return resource_string(buf, end, ptr, field_width, precision, flags); } flags |= SMALL; if (field_width == -1) { @@ -590,6 +613,7 @@ static char *pointer(const char *fmt, ch * This function follows C99 vsnprintf, but has some extensions: * %pS output the name of a text symbol * %pF output the name of a function pointer + * %pR output the address range in a struct resource * * The return value is the number of characters which would * be generated for the given input, excluding the trailing
| |