lkml.org 
[lkml]   [2008]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] mm: rework do_pages_move() to work on page_sized chunks
Brice Goglin wrote:

> + err = -ENOMEM;
> + pm = kmalloc(PAGE_SIZE, GFP_KERNEL);
> + if (!pm)

ok.... But if you need a page sized chunk then you can also do
get_zeroed_page(GFP_KERNEL). Why bother the slab allocator for page sized
allocations?


> + chunk_nr_pages = PAGE_SIZE/sizeof(struct page_to_node) - 1;

Blanks missing.



> + /* fill the chunk pm with addrs and nodes from user-space */
> + for (j = 0; j < chunk_nr_pages; j++) {

j? So the chunk_start used to be i?


Acked-by: Christoph Lameter <cl@linux-foundation.org>


\
 
 \ /
  Last update: 2008-10-16 21:55    [W:0.364 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site