Messages in this thread | | | Date | Wed, 15 Oct 2008 17:03:07 +0900 | From | "Magnus Damm" <> | Subject | Re: [PATCH] soc-camera: fix compile breakage on SH |
| |
Hi Guennadi,
On Wed, Oct 15, 2008 at 3:41 PM, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote: > Hi Magnus > > On Wed, 15 Oct 2008, Magnus Damm wrote: > >> Thanks for working on fixing the breakage. I'd prefer to wait a bit >> since there are quite a few pinmux patches queued up that may break if >> we merge a fix right now. I can fix it up later on. > > no, I would not leave the kernel in a non-compilable state even if just > for one board. Please, test a new version of the patch below. And yes, You > will have to rebase your patches, sorry. Another thing, could you also, > please, add a license / copyright header to > include/media/soc_camera_platform.h?
I'm not asking you to keep the board broken forever. It's just a question of in which order the trees are getting merged. Again, I'd rather see that this fix is put _on_top_ of the patches that are already queued up in the SuperH tree. Merging it before doesn't help anything in my opinion - especially since the change should go though the SuperH tree anyway.
Feel free to add any header you like. =)
/ magnus
| |