Messages in this thread | | | Date | Wed, 15 Oct 2008 16:31:19 -0400 | From | Arjan van de Ven <> | Subject | Re: GIT head no longer boots on x86-64 |
| |
On Wed, 15 Oct 2008 17:33:42 +0200 Jiri Slaby <jirislaby@gmail.com> wrote:
> Users usually do > is_vmalloc_addr(a) ? vfree(a) : kfree(a); > Even there it makes more sense to me. >
I would like to point out that I greatly dislike any and all such abuses. Either you vmalloc something or you kmalloc it. Doing it dynamic with no way to tell? Horrible.
(in fact I might do a patch in the opposite direction; have vmalloc() be fancy and internally try kmalloc first, if it fails, then do the expensive stuff)
but really, you need to know what you allocated.
-- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
| |