Messages in this thread | | | Date | Tue, 14 Oct 2008 15:49:16 -0700 (PDT) | Subject | Re: sparc64 allmodconfig build failure... | From | David Miller <> |
| |
From: Sven Wegener <sven.wegener@stealer.net> Date: Tue, 14 Oct 2008 23:08:17 +0200 (CEST)
> Yeah, with the default governor being any of supported governors, we > either need some ugly #ifdef mess to only export the governor that > is selected or just revert to the old code, which unconditionally > exports all governors. Or something like the patch below. With the > additional modules that I oversaw and that require the export, I'm > fine with just reverting the commit, although I think that > encapsulating the default governor decision in a built-in function > is cleaner than having modules reference different symbols depending > on configuration.
Personally I prefer the revert.
All of the alternative solutions shown far have been extremely ugly.
| |